Changelog for 1.18.0#1170
Conversation
CHANGELOG.MD
Outdated
|
|
||
| - Minimum required version of `PowerShell Core` was raised from `6.0.2` to `6.1.0` due to `6.0` having reached the end of it's support life-cycle. (#1165) | ||
| - Updated used version of `Newtonsoft.Json` to `11.0.2`. (#1165) (by @bergmeister) | ||
| - Command data files of PowerShell `6.0.2` were removed. Updated files for PowerShell `6.1.0` were added. This means that users that have customized the `UseCompatibleCmdlets` rule, need to either adapt the version string as per rule documentation or can alternatively copy in the old command data files into the `Settings` installation folder (#1075) (by @bergmeister) |
There was a problem hiding this comment.
6.1.0 because we did the PR early on. But since PowerShell patches are mostly patches of the .Net Core Runtime I don't think cmdlets or their parameters were added/renamed/removed unless you are aware of something
There was a problem hiding this comment.
No, there won't be any serious changes in PowerShell itself. It might be worth just calling this PowerShell 6.1.
There was a problem hiding this comment.
Ok. Good point. The docs of the rule already state what I said in my comment, therefore I agree to shorten it to just 6.0 keep the changelog notes rather simple
CHANGELOG.MD
Outdated
| - Fix settings file array parsing when no commas are present (#1161) (by @rjmholt) | ||
| - Ensure correct disposal with using statement (#1164) (by @bergmeister) | ||
| - Emit parsing errors as diagnostic records (#1130) (by @JamesWTruher) | ||
| - Make Invoke-Formatter cleanup its state in the same way as Invoke-ScriptAnalyzer does to avoid knock on effect on Invoke-ScriptAnalyzer when Invoke-Formatter is being called (#1121) (by @bergmeister) |
There was a problem hiding this comment.
Maybe clarify this item -- I'm not quite sure what it means
There was a problem hiding this comment.
Yes, you're right. The name of that PR was not good. Basically Invoke-ScriptAnalyzer did not do anything the first time after having called Invoke-Fornatter
Co-Authored-By: bergmeister <[email protected]>
Co-Authored-By: bergmeister <[email protected]>
|
general comment - how about change (by < PR author >) to (thanks < PR author >)? I saw that in a different repo and liked it |
JamesWTruher
left a comment
JamesWTruher
left a comment
There was a problem hiding this comment.
looks like we're very close
|
I did the 'Thanks' but only for people that are not maintainers |
* Changelog for 1.18.0 * Apply suggestions from code review Co-Authored-By: bergmeister <[email protected]> * Update CHANGELOG.MD Co-Authored-By: bergmeister <[email protected]> * Uodate PR description of bug with Invoke-Formatter to address PR feedback * address pr comment about breaking change * Apply suggestions from code review * Update with recently merged PRs
3 participants
PR Summary
Changelog for 1.18.0
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.