Skip to content

Translate RuleSuppressionID for custom rules as well#1144

Merged
bergmeister merged 3 commits intoPowerShell:developmentfrom
bergmeister:CustomRule_RuleSuppressionID
Mar 8, 2019
Merged

Translate RuleSuppressionID for custom rules as well#1144
bergmeister merged 3 commits intoPowerShell:developmentfrom
bergmeister:CustomRule_RuleSuppressionID

Conversation

@bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Feb 21, 2019

PR Summary

Fixes #1143 by translating the RuleSuppressionID for custom rules as well.

PR Checklist

@bergmeister bergmeister added this to the 1.18 milestone Feb 21, 2019
@bergmeister bergmeister marked this pull request as ready for review February 21, 2019 20:36
@bergmeister bergmeister added the (Re-)Review Needed Feedback has been addressed during PR stage or is required in the first place. label Feb 24, 2019
@jegannathanmaniganadan
Copy link
Contributor

jegannathanmaniganadan commented Mar 1, 2019

Any idea when this will get merged ? @bergmeister

@bergmeister
Copy link
Collaborator Author

bergmeister commented Mar 1, 2019 •
edited
Loading

@manigandan-jegannathan-developer
When it is reviewed and approved. Hopefully some point next week (this depends on availability of the PowerShell team members that are currently busy with publishing a RC of PowerShell Core 6.2)

@jegannathanmaniganadan
Copy link
Contributor

jegannathanmaniganadan commented Mar 1, 2019 •
edited by bergmeister
Loading

@manigandan-jegannathan-developer
When it is reviewed and approved. Hopefully some point next week (this depends on availability of the PowerShell team members that are currently busy with publishing a RC of PowerShell Core 6.2)

Thanks!

@bergmeister
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
803a0e0 
…nalyzer into CustomRule_RuleSuppressionID

# Conflicts:
#	Tests/Engine/CustomizedRule.tests.ps1
#	Tests/Engine/samplerule/samplerule.psm1
@bergmeister bergmeister merged commit a15d260 into PowerShell:development Mar 8, 2019
@jegannathanmaniganadan
Copy link
Contributor

jegannathanmaniganadan commented Mar 11, 2019

@bergmeister won't this need any version changes ? How do I get it from PS Gallery

@bergmeister
Copy link
Collaborator Author

bergmeister commented Mar 11, 2019

@manigandan-jegannathan-developer
Yes. We are planning to release a new version of PSSA (1.18) this month to the PSGallery. Installation will be as usual via Install/Update-Module

bergmeister added a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 22, 2019
@bergmeister
Translate RuleSuppressionID for custom rules as well (PowerShell#1144)
e0526bb 
* Populate RuleSuppressionID as well when translating DiagnosticRecord in custom rules

* fix NullReferenceException
@jegannathanmaniganadan jegannathanmaniganadan mentioned this pull request Sep 23, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JamesWTruher JamesWTruher JamesWTruher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area - Engine (Re-)Review Needed Feedback has been addressed during PR stage or is required in the first place.

Projects

None yet

Milestone

1.18

Development

Successfully merging this pull request may close these issues.

Unable to set RuleSuppressionID in DiagnosticRecord object from custom powershell rule

3 participants

@bergmeister @jegannathanmaniganadan @JamesWTruher