Unify reference to Microsoft.Management.Infrastructure and update System.Reflection.TypeExtensions package#1105
Merged
bergmeister merged 6 commits intoPowerShell:developmentfrom Mar 8, 2019
Conversation
…tem.Reflection.TypeExtensions package
JamesWTruher
suggested changes
Dec 6, 2018
Contributor
JamesWTruher
left a comment
JamesWTruher
left a comment
There was a problem hiding this comment.
I'm not sure that this will work. I wasn't aware that Microsoft.Management.Infrastructure was appropriate for core.
Collaborator
Author
|
Why? All I am changing is to make fullclr use the latest released version and eliminate code-duplication, the NuGet package supports net451 and netstandard1.6 or are you saying you wouldn't expect it to work at runtime? The Nuget reference is needed for coreclr and fullclr, otherwise the project won't compile. |
bergmeister
added
the
(Re-)Review Needed
rjmholt
approved these changes
Mar 5, 2019
Contributor
|
It looks like we were already pulling in MMI for netstandard, I assume for DSC rules of some kind. I'm guessing that this MMI will work on Core to the extent that DSC does. Anyway, it just looks like a merge of versions, so that looks good to me |
rjmholt
approved these changes
Mar 5, 2019
…nalyzer into NuGetupdates # Conflicts: # Rules/Rules.csproj
rjmholt
approved these changes
Mar 5, 2019
JamesWTruher
approved these changes
Mar 7, 2019
bergmeister
added a commit
to bergmeister/PSScriptAnalyzer
that referenced
this pull request
Mar 22, 2019
…tem.Reflection.TypeExtensions package (PowerShell#1105) * Unify reference to Microsoft.Management.Infrastructure and update System.Reflection.TypeExtensions package * trigger ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
As per title
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.