Change PSGallery rules to remove 2 rules#1037
Merged
bergmeister merged 1 commit intodevelopmentfrom Jul 13, 2018
Merged
Conversation
bergmeister
approved these changes
Jul 13, 2018
Collaborator
There was a problem hiding this comment.
Thanks for updating this file to keep it in sync. I don't think that the new rules in PSSA 1.17.1 would be useful to the PSGallery but just wanted to update you that there has been a new release, which includes a lot of misc. bug fixes and perf improvements
bergmeister
pushed a commit
to bergmeister/PSScriptAnalyzer
that referenced
this pull request
Mar 22, 2019
…inText and PSAvoidUsingUserNameAndPasswordParams rules (PowerShell#1037)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The PowerShell Gallery currently uses the set of rules in this preset configuration to inform module authors of problems in their modules. The 2 rules in question (AvoidUsingConvertToSecureStringWithPlainText' and 'AvoidUsingUserNameAndPasswordParams' are problematic in that:
This changelist acknowledges reality: since the violation reports are not of value to module authors, we'll drop these rules.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets. Please mark anything not applicable to this PRNA.WIP:to the beginning of the title and remove the prefix when the PR is ready