Use Perl_signbit unconditionally for POSIX::signbit() #18441
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
POSIX::signbit()had a fallback implementation for the casePerl_signbitis not defined, but this code is apparently broken because it returns wrongly non-zero (true) value forsignbit(+0.0).Currently
Perl_signbitis always defined (either as a macro or as a function), so it seems to be better to use it unconditionally.Additionally, unused macro
c99_signbitis deleted, which is also apparently broken because there is nosignbitl()in C99.