improve t/porting/globvar.t portability #21637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POSIX specifies well defined output for nm -P This will hopefully run this test on more platforms, including old AIX, for which nm produces a different output from what the test expected. Part of Perl#21623
nm on AIX can list both local and global definitions for the same variable, which meant the parsing would delete the first instance from %exported, but then add the second to %unexported, failing the test. This didn't fail on AIX 5 because the default nm output didn't match what the code expected when checking for PL_Yes, and so the entire test script skipped. Fixes Perl#21623
Tux
approved these changes
Nov 14, 2023
Tux
approved these changes
Nov 14, 2023
Tux
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two basic changes:
nm -P objectfileinstead ofnm objectfile. POSIX defines a specific layout fornm -P ...Tested on smokes, AIX 5, HP-UX 11.31 (Tux's machine)
Fixes #21623