Skip to content

Rename quantization -> quantization_bins #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bpkroth merged 41 commits into from
Aug 16, 2024
Merged

Rename quantization -> quantization_bins #844

bpkroth merged 41 commits into from
Aug 16, 2024

Conversation

@motus
Copy link
Member

@motus motus commented Aug 15, 2024 •
edited
Loading

Merge after (or instead of) #835

diff from #835 :: https://github.com/motus/MLOS/pull/15/files

Closes #803

motus and others added 30 commits August 5, 2024 16:38
@motus
monkey patch ConfigSpace.Hyperparameter.sample_value() with value qua…
7f536a8 
…ntization
@motus
add quantization to some tunables in unit tests
f54587e
@motus
Merge branch 'main' into sergiym/tunable/quantization
d4516db
@motus
use number of bins instead of quantization interval length in mlos_be…
86e1557 
…nch (configs and internally)
@motus
fix quantized_values to use quantization bins
61e9cc2
@motus
typo: accidentally removed quantization defs
de657a4
@motus
make tunable size tests work
ecc4b75
@motus
minor fix to the grid search unit tests (new data type for cardinalit…
5118454 
…y value of tunable)
@motus
mypy fixes to grid search
ef0486d
@motus
disable pylint warning in _tunable_to_configspace
565b3d7
@motus
minor docstring formatting
1c8ca09
@motus
Merge branch 'main' into sergiym/tunable/quantization_bins
5087c94
@motus
move monkey patching to a standalone function that can be used in uni…
28731c6 
…t tests
@motus
better type annotations
2b6c863
@motus
add quantization to ConfigurationSpace parameters in unit tests
6c5401b
@motus
docstring formatting
ebe8730
@motus
better parameter naming
6b76039
@motus
docstring fix
3e984e1
@motus
add quantization patching unit tests; bugfix in monkey patch code
1b13e2d
@motus
imports formatting
d6eace8
@motus
add unit tests for repatching the same method multiple times
eaddd89
@motus
fix the repatching unit test
7c8efac
@motus
fix the repatching unit test
7e8c6b4
@motus
try a new value of optim. score for FLAML
cff2eb7
@motus
new version of FLAML produces a different config
53befe4
@motus
explicitly import RandomState to make pylint happy
6e0133f
@motus
reorder imports
a8fc00c
@motus @bpkroth
Update mlos_bench/mlos_bench/optimizers/convert_configspace.py
da8ab21 
Co-authored-by: Brian Kroth <[email protected]>
@motus @bpkroth
Update mlos_bench/mlos_bench/optimizers/convert_configspace.py
b3a5278 
Co-authored-by: Brian Kroth <[email protected]>
@motus
roll back the change in unit tests due to (faulty) FLAML version
55cd8f4
bpkroth and others added 10 commits August 14, 2024 13:58
@motus motus self-assigned this Aug 15, 2024
@motus motus requested a review from a team as a code owner August 15, 2024 20:06
bpkroth
bpkroth approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs rebasing after #835

@bpkroth bpkroth merged commit fadfacb into microsoft:main Aug 16, 2024
@bpkroth bpkroth mentioned this pull request Aug 16, 2024
Merged
bpkroth added a commit that referenced this pull request Aug 16, 2024
@bpkroth
Bump version: 0.6.0 → 0.6.1 (#845)
6134b14 
Bump version after #844 which represents a breaking config schema
change.
@motus motus deleted the sergiym/tunable/quantization_bins_rename branch August 16, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpkroth bpkroth bpkroth approved these changes

Assignees

@motus motus

Labels

mlos-bench ready for review Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement quantization for ConfigSpace >= 1.0

2 participants

@motus @bpkroth