feat: switch core http to okhttp #10069
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukaschultze
reviewed
Nov 9, 2022
| raw: result.raw, | ||
| toArrayBuffer: () => Uint8Array.from(result.raw.toByteArray()).buffer, | ||
| raw: raw, | ||
| toArrayBuffer: () => Uint8Array.from(raw.toByteArray()).buffer, |
Contributor
There was a problem hiding this comment.
Uint8Array.from iterates over each element of the source array and copies it to the new array.
If you use pass a java.nio.ByteBuffer as the argument it'll create the TypedArray from a pointer (O(1) performance and no extra memory allocation).
Creating a buffer from 1MB of data takes about ~700ms, wrapping it in a java.nio.ByteBuffer takes only 3ms
toArrayBuffer: () => {
const arr = raw.toByteArray();
const bb = java.nio.ByteBuffer.wrap(arr);
const buffer = ArrayBuffer.from(bb);
return buffer;
},
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Will fill details later.
Notes:
other than doing some body decoding in the main thread, this implementation already covers all of the current API + cancellation. Ideeally we should have the web spec AbortController ready for this