Merged
Conversation
fdiblen
requested changes
Aug 22, 2024
Member
fdiblen
left a comment
There was a problem hiding this comment.
Nice work, @lyashevska! I left a few minor comments.
Co-authored-by: fdiblen <[email protected]>
Co-authored-by: fdiblen <[email protected]>
Co-authored-by: fdiblen <[email protected]>
Co-authored-by: fdiblen <[email protected]>
fdiblen
requested changes
Aug 22, 2024
Member
fdiblen
left a comment
There was a problem hiding this comment.
Almost there! You have two more small fixes ;)
Co-authored-by: fdiblen <[email protected]>
Co-authored-by: fdiblen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes zenodo integration optional.
Related issues:
Install the requirements
Test 1:
Step-1:
Run the command below and say 'yes' to zenodo question
Step-2:
Run the command below and say 'no' to zenodo question
What to check:
You should see the files below only when you say 'yes':
Check if there are mentions of zenodo or doi in any file of the generated package.
Test 2: