Conversation
Collaborator
|
This is great, thanks! One small additional request: could you perhaps remove the line with Ready to merge after that, afaic. |
Collaborator
|
Oh, actually, the markdown-link-check action has the same issue... Would be super nice if that was fixed too :D |
Contributor
Author
|
Should the |
Collaborator
|
No cffconvert is already very specific, only runs when the cff file is updated. Lgtm! |
Collaborator
|
Thanks for both these great PRs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As noticed by @BSchilperoort, the CI currently runs twice when new commits are pushed to a PR. This can be limited to only run on the
mainbranch itself or PRs tomain.