I approved the changes, but retriggered the GH Actions workflows, because three of them failed (Windows runs), let's see if they were intermittent failures. Did you check the failures @apalha? Were they related to this PR or something pre-existing?

I checked the links manually and they seem to work. Don't know why they fail but I've seen that before with this particular workflow...

Ah, I see it: the links are forwarding, so they work when clicked, but the workflow doesn't catch that.

I did miss that there were some tests failing 😬 don't know about that. It's Windows with Python 3.7 and up:

Edited:

It's an assertion error with this line (57-58) in test_project.py

    pip_output = run([f'{bin_dir}pip3', 'install', '--editable', '.[dev]'], result.project)
    assert pip_output.returncode == 0

This is the error message (as far as I can detect):

ERROR: Could not install packages due to an OSError: [WinError 5] Access is denied: 'c:\\hostedtoolcache\\windows\\python\\3.7.9\\x64\\lib\\site-packages\\~arkupsafe\\_speedups.cp37-win_amd64.pyd'
Consider using the `--user` option or check the permissions.

I propose moving this to a new issue and dealing with it separately.

@bvreede thanks for looking into that! Indeed deserves its own issue.

@bvreede do you want to make the issue, or should I?

See #326 :)

Thanks!

Just saw this now. Yes, I saw the errors and they were triggered by older links. I see that you already noticed that. Thanks!