restore uvloop.new_event_loop and other missing uvloop members to typing#573
Merged
fantix merged 2 commits intoMagicStack:masterfrom Oct 15, 2023
Merged
Conversation
graingert
commented
Oct 14, 2023
graingert
force-pushed
the
uvloop-missing-nel-install-elp-etc
branch
from
e08494f to
83fbb49
Compare
graingert
commented
Oct 14, 2023
Contributor
Author
There was a problem hiding this comment.
adding this file removed the useful members like 'new_event_loop' which is needed for asyncio.Runner(...)
graingert
commented
Oct 14, 2023
graingert
commented
Oct 14, 2023
graingert
commented
Oct 14, 2023
graingert
force-pushed
the
uvloop-missing-nel-install-elp-etc
branch
2 times, most recently
from
0370a92 to
ec9c6ce
Compare
graingert
changed the title
graingert
commented
Oct 14, 2023
graingert
commented
Oct 14, 2023
graingert
force-pushed
the
uvloop-missing-nel-install-elp-etc
branch
from
d887fa4 to
7ea847c
Compare
Contributor
Author
|
@fantix can I get a review on this please? It's blocking mypy in unicorn |
fantix
reviewed
Oct 15, 2023
| loop.set_debug(debug) | ||
| return loop.run_until_complete(wrapper()) | ||
| finally: | ||
| if _typing.TYPE_CHECKING: |
Member
There was a problem hiding this comment.
Can we just inline the typing and omit this TYPE_CHECKING check?
Contributor
Author
There was a problem hiding this comment.
I tried that, if you see the history of the PR, but it took too many changes
Member
There was a problem hiding this comment.
I see now. What about adding new_event_loop to __init__.pyi?
Contributor
Author
There was a problem hiding this comment.
I tried that first also and it means the other members aren't type checked
fantix
approved these changes
Oct 15, 2023
| loop.set_debug(debug) | ||
| return loop.run_until_complete(wrapper()) | ||
| finally: | ||
| if _typing.TYPE_CHECKING: |
Member
There was a problem hiding this comment.
I see now. What about adding new_event_loop to __init__.pyi?
fantix
added a commit
that referenced
this pull request
Oct 22, 2023
Changes ======= * Drop support of Python 3.7 and update CI (#578) (by @fantix in ee5ad26 for #578) Fixes ===== * Restore uvloop.new_event_loop and other missing uvloop members to typing (#573) (by @graingert in 5c500ee for #573) * Fix docstring of loop.shutdown_default_executor (#535) (by @Gelbpunkt in 919da56 for #535) * Fix CI status badge (#522) (by @shuuji3 in 0e9ff6c for #522)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.