Create transitioning-contractor-code-to-innersource-model#377
Merged
spier merged 28 commits intoInnerSourceCommons:mainfrom Oct 10, 2022
Merged
Create transitioning-contractor-code-to-innersource-model#377spier merged 28 commits intoInnerSourceCommons:mainfrom
spier merged 28 commits intoInnerSourceCommons:mainfrom
Conversation
claredillon
requested review from
NewMexicoKid,
cewilliams,
lenucksi and
spier
as code owners
claredillon
changed the title
Member
Author
|
@zkoppert - can you take a look at this please and see if you would add any details. It would be great if we could add some explicit steps to transition if we can... |
Member
|
Nice job @claredillon! I added the This also results in our markdown syntax linter to check this file, which is why you should have received some email notifications with syntax warnings. I tried to fix some of them but not sure if I found all. |
zkoppert
approved these changes
Dec 20, 2021
Member
zkoppert
left a comment
zkoppert
left a comment
There was a problem hiding this comment.
Thanks so much for writing this up Clare!!
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Zack Koppert <[email protected]>
Co-authored-by: Zack Koppert <[email protected]>
spier
reviewed
Dec 20, 2021
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
spier
reviewed
Dec 20, 2021
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
spier
reviewed
Dec 20, 2021
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Zack Koppert <[email protected]>
spier
reviewed
Dec 20, 2021
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
spier
reviewed
Dec 20, 2021
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Zack Koppert <[email protected]>
spier
requested changes
Jan 7, 2022
Member
spier
left a comment
spier
left a comment
There was a problem hiding this comment.
@claredillon great start. 🚀
I worked in some of Zack's feedback and added further comments of my own.
It would be great to get this pattern merged as Initial in the short term, to gather further feedback from the Community before publishing it in our book.
Btw does anything speak against turning this PR from "Draft" into "Ready for review"?
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Show resolved
Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
spier
reviewed
Jan 8, 2022
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
Member
|
@claredillon It looks like some of @spier's comments are directed towards your part of the content. Just dropping your name here as a reminder to address those comments. |
spier
added
1-initial
Member
|
@claredillon how shall we proceed on this PR? |
…e-model.md Co-authored-by: Zack Koppert <[email protected]>
…e-model.md Co-authored-by: Sebastian Spier <[email protected]>
…e-model.md Co-authored-by: Sebastian Spier <[email protected]>
…e-model.md Co-authored-by: Sebastian Spier <[email protected]>
…e-model.md Co-authored-by: Sebastian Spier <[email protected]>
spier
reviewed
Oct 10, 2022
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
spier
reviewed
Oct 10, 2022
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
…e-model.md Co-authored-by: Sebastian Spier <[email protected]>
…e-model.md Co-authored-by: Sebastian Spier <[email protected]>
Extended the patlet description. Removed some comments for other editors.
spier
reviewed
Oct 10, 2022
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
spier
reviewed
Oct 10, 2022
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
spier
reviewed
Oct 10, 2022
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md
Outdated
Show resolved
Hide resolved
claredillon
commented
Oct 10, 2022
Member
Author
claredillon
left a comment
claredillon
left a comment
There was a problem hiding this comment.
I think we're good to go now @spier ??
spier
approved these changes
Oct 10, 2022
Member
spier
left a comment
spier
left a comment
There was a problem hiding this comment.
Discussed the remaining points with @claredillon, and we fixed all open comment threads.
Will merge this shortly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new pattern as discussed in #375