Skip to content

chore: updated urllib3 to 2.5.0 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joheriks wants to merge 1 commit into from
Closed

chore: updated urllib3 to 2.5.0 #15

joheriks wants to merge 1 commit into from

Conversation

@joheriks
Copy link

@joheriks joheriks commented Jun 26, 2025 •
edited
Loading

PR summary

Latest release of urllib3 contains a couple of medium sev CVE fixes. This PR bumps the urllib3 requirements to 2.5.0 for compliance.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Unit tests pass after the upgrade:

% make test
python3 -m pytest --cov=ibm_code_engine_sdk test/unit
===================================================================== test session starts =====================================================================
platform darwin -- Python 3.12.1, pytest-8.3.5, pluggy-1.6.0
rootdir: /Users/jweeriks/dev/code-engine-python-sdk
configfile: pyproject.toml
plugins: cov-5.0.0, rerunfailures-15.1, anyio-4.7.0, requests-mock-1.12.1
collected 489 items

test/unit/test_code_engine_v2.py ...................................................................................................................... [ 24%]
....................................................................................................................................................... [ 55%]
....................................................................................................................................................... [ 85%]
.............................................................                                                                                           [ 98%]
test/unit/test_common.py ..                                                                                                                             [ 98%]
test/unit/test_ibm_cloud_code_engine_v1.py ......                                                                                                       [100%]

---------- coverage: platform darwin, python 3.12.1-final-0 ----------
Name                                              Stmts   Miss  Cover
---------------------------------------------------------------------
ibm_code_engine_sdk/__init__.py                       3      0   100%
ibm_code_engine_sdk/code_engine_v2.py              7184    832    88%
ibm_code_engine_sdk/common.py                        13      0   100%
ibm_code_engine_sdk/ibm_cloud_code_engine_v1.py      58      4    93%
ibm_code_engine_sdk/version.py                        1      0   100%
---------------------------------------------------------------------
TOTAL                                              7259    836    88%


===================================================================== 489 passed in 6.71s =====================================================================

@joheriks
chore: updated urllib3 to 2.5.0
1113597 
Signed-off-by: Johannes Eriksson <[email protected]>
@joheriks
Copy link
Author

joheriks commented Sep 8, 2025

Closing PR as this change has already been made in 20cc46a

@joheriks joheriks closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@joheriks