Skip .container.known_envs
#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR addresses test failures caused by a recent Symfony change (symfony/symfony#62558) by removing the .container.known_envs parameter from container instances before comparison. The fix ensures that XML and PHP container dumps can be accurately compared without interference from this internal Symfony parameter.
Key changes:
- Added removal of
.container.known_envsparameter after loading both XML and PHP containers - Applied the fix consistently across test and production validation code
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/SymfonyXmlFixturesTest.php | Removes .container.known_envs parameter after loading XML and PHP containers in test validation |
| src/ConvertCommand.php | Removes .container.known_envs parameter after loading XML and PHP containers in command validation logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests error related to symfony/symfony#62558
This parameter is added only by the XML loader, so the comparison is wrong.