Conversation
…ration tests, and adds verbose comments on mock entities.
googlebot
added
the
cla: yes
jerjou
suggested changes
Dec 2, 2016
language/analysis/README.md
Outdated
| We can then run the assembled JAR file with the `java` command. The variable $COMMAND takes | ||
| three values `entities`, `sentiment` or `syntax`. | ||
| six values `entities-text`, `entities-file`, `sentiment-text`, `sentiment-file`, | ||
| `syntax-text`, or `syntax-file`. |
Contributor
There was a problem hiding this comment.
Oi. Perhaps would be cleaner to just detect a gcs uri? As in:
if (command.equals("entities")) {
if (text.startsWith("gs://")) {
app.analyzeEntitiesFile(text);
} else {
app.analyzeEntitiesText(text);
}
} // ... etcinside Analyze.java
Member
There was a problem hiding this comment.
That would moves us toward writing library code in the snippets, and the other 6 languages have separate snippets for raw strings vs gcs files, so Java would need to do the same to fit into the docs where the other snippets live.
Contributor
Author
There was a problem hiding this comment.
I think he just means in the command parser, I am in favor of simplifying the args parser for a lighter-weight usage string.
| return response.getEntitiesList(); | ||
| } | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
Perhaps:
* Gets {@link Entity}s from the contents of the object at the given GCS {@code path}
Otherwise it sounds like it's looking for entities in the path string itself. (here and below)
|
|
||
| // Assert | ||
| assertThat((double)sentiment.getMagnitude()).isGreaterThan(1.0); | ||
| assertThat((double)sentiment.getScore()).isWithin(0.0); |
Contributor
There was a problem hiding this comment.
Seems a bit brittle, no? Perhaps isWithin(0.1)?
jerjou
approved these changes
Dec 2, 2016
jmdobry
approved these changes
Dec 3, 2016
lesv
reviewed
Dec 5, 2016
Contributor
lesv
left a comment
lesv
left a comment
There was a problem hiding this comment.
LGTM - though shouldn't we have used "${QUOTE}" https://google.github.io/styleguide/shell.xml#Use_Local_Variables ?? (in your README.md)
Contributor
Author
|
Sorry for merging a little aggressively and good catch - I'll fix the style for shell variables in a separate PR if that works. Should we also be making |
Contributor
|
I think that's more inline with the style guide. (ie. YES) |
Contributor
Author
|
SGTM. |
Shabirmean
pushed a commit
that referenced
this pull request
Nov 14, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [junit:junit](http://junit.org) ([source](https://togithub.com/junit-team/junit4)) | `4.13.1` -> `4.13.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow).
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [junit:junit](http://junit.org) ([source](https://togithub.com/junit-team/junit4)) | `4.13.1` -> `4.13.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow).
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Google Cloud Storage (GCS) examples and tests to be at parity with other samples for inclusion in snippets.