Skip to content
This repository was archived by the owner on Mar 14, 2024. It is now read-only.

Only run percy against PRs.#2592

Merged
samthor merged 1 commit intomasterfrom
task/run-percy-less
Apr 15, 2020
Merged

Only run percy against PRs.#2592
samthor merged 1 commit intomasterfrom
task/run-percy-less

Conversation

@robdodson
Copy link
Contributor

We hit our free Percy limit of 5000 screenshots this month so I upgraded us to the paid plan. We made two changes recently that I think contributed to this overage:

  • We were running Percy every time something got merged into master, even if we were just merging in markdown files of text. This also means we were running it at least twice for every PR (once during the PR review and once when it merged).
  • I added an additional size to our .percy.config.yml file so we could take screenshots of tablets. So every PR generates at least three screenshots per synchronization.

Changes proposed in this pull request:

  • Only run percy against pull requests. Don't bother running it when stuff merges into master. We shouldn't be pushing directly to master anyway. Hopefully this cuts down on a lot of excess.

@robdodson robdodson requested a review from samthor as a code owner April 15, 2020 01:48
@googlebot googlebot added the cla: yes Contributor has signed the CLA label Apr 15, 2020
@samthor
Copy link
Contributor

samthor commented Apr 15, 2020

👍

@samthor samthor merged commit 3278af5 into master Apr 15, 2020
@samthor samthor deleted the task/run-percy-less branch April 15, 2020 01:49
@netlify
Copy link

netlify bot commented Apr 15, 2020

Deploy preview for web-dev-staging ready!

Built with commit 265d1ce

https://deploy-preview-2592--web-dev-staging.netlify.com

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes Contributor has signed the CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants