Conversation
|
Deploy preview for web-dev-staging ready! Built with commit 8699d3e |
|
I realized that we can just do |
|
I guess the next question is to figure out where this fits in our github actions. |
package.json
Outdated
| "watch:rollup": "chokidar \"src/lib/**/*.{js,scss}\" -c \"npm run rollup\"", | ||
| "watch:sass": "chokidar \"src/styles/**/*.scss\" -c \"npm run sass\"", | ||
| "watch:test": "TEST_MODE=dev npm-run-all clean build:rollup --parallel watch:rollup karma" | ||
| "watch:test": "TEST_MODE=dev npm-run-all clean rollup --parallel watch:rollup karma" |
There was a problem hiding this comment.
I hate to nitpick but this is now "watch:test:unit" rather than integration tests, right?
samthor
left a comment
There was a problem hiding this comment.
So this is fine for now but I still think the npm commands are a bit confusing.
A semi-serious alternative proposal: we just have one test target, but that itself spawns Karma or (even better) Puppeteer. Internally that test runner might support e.g. "--type=unit" or "--type=integration". Just my 2c.
yeah I agree. Because the integration tests will probably be a lot slower than the component specific unit tests I wanted to separate them out. But naming leaves a lot to be desired.
hm yeah maybe we could do something like |
Changes proposed in this pull request:
Kinda curious what folks think about the npm scripts.