This repository was archived by the owner on Mar 14, 2024. It is now read-only.
Merged
Conversation
robdodson
reviewed
Jul 29, 2019
| stroke-dashoffset: 1000; | ||
| animation: sparkline-dash-animation 300ms linear forwards; | ||
| stroke-linecap: round; | ||
| // TODO(robdodson): This doesn't animate even in the old site. |
Contributor
There was a problem hiding this comment.
I'm cool just removing this stuff. I think Eric added it originally and my knowledge of SVG animation is nil :P
| firstUpdated() { | ||
| this.cursorElement_ = this.renderRoot.querySelector("#cursor"); | ||
| this.scoreElement_ = this.renderRoot.querySelector("#score"); | ||
| this.announcerElement_ = this.querySelector(".sr-announcer"); |
Contributor
There was a problem hiding this comment.
maybe we should turn this into an id as well?
Contributor
Author
There was a problem hiding this comment.
as discussed in chat—no!
| get fill() { | ||
| return this.hasAttribute("fill"); | ||
| } | ||
| set demo(demo) { |
Contributor
There was a problem hiding this comment.
Do you want to keep this or remove it before we land?
Contributor
Author
There was a problem hiding this comment.
I'm less worried since this isn't hundreds of kbs of data.
robdodson
approved these changes
Jul 29, 2019
Contributor
robdodson
left a comment
robdodson
left a comment
There was a problem hiding this comment.
LGTM, just curious about follow up on a few comments.
samthor
force-pushed
the
v2+fix-sparkline
branch
from
59f3e9e to
cc05b75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get sparkline working in v2.
This is a reasonably big change and makes quality-of-life improvements over v1.
ResizeObserver(or fallback toresize) to resize the elementscoreHeightand friends—reads size from element size