core(plugins): support scoped npm packages#16550
Merged
connorjclark merged 1 commit intoGoogleChrome:mainfrom Jun 25, 2025
Merged
core(plugins): support scoped npm packages#16550connorjclark merged 1 commit intoGoogleChrome:mainfrom
connorjclark merged 1 commit intoGoogleChrome:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Thanks! Will need a couple things first before landing this:
|
Contributor
Author
|
done |
Collaborator
|
Linting is failing. I tried pushing to the forked branch but for some reason GitHub is not allowing me. Here is what I wanted to patch in. |
Contributor
Author
|
okay, should be good now, i applied your patch |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
currently we can't use plugins that are namespaced, e.g. @myorg/lighthouse-plugin-blabla
im simply splitting on / and checking if the second part starts with the correct prefix.
Related Issues/PRs