Conversation
.github/workflows/publish.yml
Outdated
| - run: yarn | ||
|
|
||
| - name: bash $GITHUB_WORKSPACE/.github/scripts/bump-nightly-version.sh | ||
| - uses: JS-DevTools/npm-publish@v1 |
There was a problem hiding this comment.
I believe we want to peg to a specific hash since the tag can be changed at any time
There was a problem hiding this comment.
aside: do we actually need this? it seems like we don't use any of their touted improvements over just npm publish and if we can avoid giving out our NPM_TOKEN with a line or two, that feels worth it :)
There was a problem hiding this comment.
Only publishes if the version number in package.json differs from the latest on NPM
hmm..does npm even let you republish the latest/any version?
There was a problem hiding this comment.
not that I'm aware of. but also aren't we publishing a brand new version every time guaranteed?
| # Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| # Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. | ||
| ## | ||
| # TMP DELETE ME |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
friggne actions failing
Co-authored-by: Paul Irish <[email protected]>
|
|
||
| set -euxo pipefail | ||
|
|
||
| DATE=$(date '+%Y%m%d') |
There was a problem hiding this comment.
(i wrote a comment but it disappeared 😢 )
since this publishes in the morning with today's date.. it does mean that commits that land on a day (say December 9th) are not in the 1209 release.
date --date="yesterday" '+%Y%m%d'fixes that.
also this --date flag for date is in gnu date but not bsd/mac date. so doesnt work on mac but should be fine on CI
5 participants
part of #11734
I modeled the version string based on how typescript does it https://www.npmjs.com/package/typescript/v/4.2.0-dev.20201208