tests: update flaky 3p facades smoke test#11786
Merged
patrickhulce merged 3 commits intomasterfrom Dec 8, 2020
Merged
Conversation
Beytoven
approved these changes
Dec 8, 2020
Collaborator
|
nice I was going to ask about this one :) only one more CI issue to go 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The third-party facades smoke test is flaky in CI. The YT embed transfer size sometimes exceeds the bounds of the expectation.
Considering the test is already lenient with the number of subresources, I think it's best to make the transfer size super lenient as well.