Conversation
connorjclark
approved these changes
Dec 8, 2020
Collaborator
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
LGTM b/c the publish scripts do this https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/scripts/release/prepare-package.sh#L32 and at this point we do want this output visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when looking at CI logs i sometimes gotta inspect the
yarn buildoutput. (example)99% of it is all the filenames that went into the
npm pack. IMO these don't add value, especially not in the CI scenario.now, no more noisy output. we just got a filename when it succeeds: