core(pwa): remove load-fast-enough-for-pwa audit#11764
Merged
devtools-bot merged 12 commits intomasterfrom Dec 9, 2020
Merged
Conversation
adamraine
changed the title
adamraine
approved these changes
Dec 4, 2020
Contributor
adamraine
left a comment
adamraine
left a comment
There was a problem hiding this comment.
LGTM. I think any necessary changes are covered by CI.
connorjclark
reviewed
Dec 8, 2020
Collaborator
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
core(load-fast-enough-for-pwa): remove audit ?
bye bye
brendankenny
approved these changes
Dec 9, 2020
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
// Ignore speed test; just verify that it ran.
A fitting send-off summary :)
🎆 🎆 ⚱️ 🎆 🎆
|
|
||
| const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings); | ||
|
|
||
| class LoadFastEnough4Pwa extends Audit { |
Contributor
There was a problem hiding this comment.
wow, the class name made it all the way to the end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The perf test in PWA has mostly just ended up adding extra confusion.
In a discussion in xfunctional August, we had consensus on removing the requirement from the PWA section.
Naturally anyone evaluating their PWA can also look at the Perf section. So it's all groovy.
fixes #10943