tests: update failing trace webtest to use Tooltip module#11731
Merged
devtools-bot merged 4 commits intomasterfrom Dec 1, 2020
Merged
tests: update failing trace webtest to use Tooltip module#11731devtools-bot merged 4 commits intomasterfrom
devtools-bot merged 4 commits intomasterfrom
Conversation
Contributor
|
The reason the test wasn't failing is that the getter was previously implicitly calling |
connorjclark
changed the title
patrickhulce
approved these changes
Dec 1, 2020
Collaborator
|
@connorjclark FYI this is failing the devtools check with |
Collaborator
Author
|
weird, it works for me locally even after I clear |
connorjclark
commented
Dec 1, 2020
| ${{ env.BLINK_TOOLS_PATH }} | ||
| ${{ github.workspace }}/lighthouse/.tmp/chromium-web-tests/content-shells | ||
| key: ${{ runner.os }}-${{ hashFiles('lighthouse/.github/workflows/devtools.yml', 'lighthouse/lighthouse-core/test/chromium-web-tests/*', 'lighthouse/clients/devtools-entry.js', 'lighthouse/clients/devtools-report-assets.js', 'lighthouse/build/build-bundle.js', 'lighthouse/build/build-dt-report-resources.js') }} | ||
| key: ${{ runner.os }}-${{ hashFiles('third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/*.js', 'lighthouse/.github/workflows/devtools.yml', 'lighthouse/lighthouse-core/test/chromium-web-tests/*', 'lighthouse/clients/devtools-entry.js', 'lighthouse/clients/devtools-report-assets.js', 'lighthouse/build/build-bundle.js', 'lighthouse/build/build-dt-report-resources.js') }} |
Collaborator
Author
There was a problem hiding this comment.
I assumed the test files were already apart of this hash. This should fix CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed here: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2555060
I'd expect that change to fail this test https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/test/webtests/http/tests/devtools/lighthouse/lighthouse-view-trace-run.js;l=36;drc=b736005f57eccddf8dd024872552f1bfb0264682 but it didn't. @TimvdLippe I assumed
test/webtestsrun in CQ, is that true?