core(console): replace ConsoleMessages and RuntimeExceptions artifacts#11663
Merged
patrickhulce merged 62 commits intoGoogleChrome:masterfrom Dec 12, 2020
Merged
core(console): replace ConsoleMessages and RuntimeExceptions artifacts#11663patrickhulce merged 62 commits intoGoogleChrome:masterfrom
patrickhulce merged 62 commits intoGoogleChrome:masterfrom
Conversation
warrengm
changed the title
warrengm
changed the title
Contributor
Author
|
I'll work on making the changes! |
...mium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt
Outdated
Show resolved
Hide resolved
…hthouse/lighthouse-successful-run-expected.txt
| @@ -733,4 +730,3 @@ viewport-ad-density | |||
| visual-order-follows-dom | |||
| without-javascript | |||
| works-offline | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| works-offline | |
| works-offline | |
Collaborator
There was a problem hiding this comment.
I guess I've found a bug in GitHub suggestions 😆
…hthouse/lighthouse-successful-run-expected.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates a new
Consolegatherer that collects all messages from the console in a single artifact. It subsumes theConsoleMessagesandRuntimeExceptionsgatherers and adds new functionality to collectconsoleAPI calls.Open questions:
console.errorcalls in the console errors audit? My guess is no but want to confirm since it's now trivial to changeRelated Issues/PRs
Fixes #11597