misc(build): fix bundling publisher ads plugin in Lightrider#11648
Merged
connorjclark merged 1 commit intoGoogleChrome:masterfrom Dec 3, 2020
Merged
misc(build): fix bundling publisher ads plugin in Lightrider#11648connorjclark merged 1 commit intoGoogleChrome:masterfrom
connorjclark merged 1 commit intoGoogleChrome:masterfrom
Conversation
patrickhulce
approved these changes
Nov 10, 2020
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
thanks @warrengm! seems good to me and I couldn't find any other isDevtools pieces we might have missed after grepping around
I can't verify in LR though so I'll defer to @connorjclark on that one :)
connorjclark
approved these changes
Nov 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should have been in #11366
Tested by building the bundle in lightrider before and after this change.