This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Expand "use strict" use & drop (broken) old Opera mixedcontent support #3961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the IIFE (immediately-invoked function expression) surrounding `localPlatformRegexp`, it's never worked. `this.userAgent` is undefined during the execution, and the else is always taken, resulting in `chromium` being the platform always. Signed-off-by: Nick Semenkovich <[email protected]>
Contributor
Author
|
@jsha for review, unless anyone else wants to look at the chrome code :) |
chromium/rules.js
Outdated
Member
There was a problem hiding this comment.
t should be scoped inside the for loop, right?
Member
|
LGTM except for that one nit. |
Signed-off-by: Nick Semenkovich <[email protected]>
Contributor
Author
|
Fixed -- thanks! |
Contributor
Author
|
Merging per LGTM above. |
semenko
added a commit
that referenced
this pull request
Jan 25, 2016
Expand "use strict" use & drop (broken) old Opera mixedcontent support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this fun bug while expanding "use strict" for some ES6 features:
Because of the IIFE (immediately-invoked function expression) surrounding
localPlatformRegexp, it's never worked.this.userAgentis undefined during execution, and the else is always taken, resulting inchromiumbeing the platform -- always.Let's just rip this out, since it hasn't worked and
mixedcontentsupport has been dead for a while in Chrome (and FF 23+, and Opera 23+).In the future, we should consider allowing Chrome users to enable
mixedcontentrules, similar to the FF behavior.Signed-off-by: Nick Semenkovich [email protected]