This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Fix Travis lint errors and regressions on wildcards, follow up #19479 #19531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipboy96
reviewed
Aug 30, 2020
| try { | ||
| new URL(`http://${host}/`); | ||
| return true; | ||
| } catch { |
Contributor
There was a problem hiding this comment.
It's possible to fix the lint error without removing this code completely, just replace this line with:
} catch (_) {
Collaborator
Author
There was a problem hiding this comment.
It seems that the URL constructor throw TypeError only. And it will not throw error for some common invalid URLs.
> try { new URL('https://*...,example.com/'); console.log('ok'); } catch(error) { console.log(error); }
ok
> try { new URL(123); console.log('ok'); } catch(error) { console.log(error); }
TypeError [ERR_INVALID_URL]: Invalid URL: 123
at onParseError (internal/url.js:256:9)
at new URL (internal/url.js:332:5)
at repl:1:7
at Script.runInThisContext (vm.js:120:18)
at REPLServer.defaultEval (repl.js:433:29)
at bound (domain.js:427:14)
at REPLServer.runBound [as eval] (domain.js:440:12)
at REPLServer.onLine (repl.js:760:10)
at REPLServer.emit (events.js:327:22)
at REPLServer.EventEmitter.emit (domain.js:483:12) {
input: '123',
code: 'ERR_INVALID_URL'
}
undefinedThe disable_on_site will validate the hostname and returns an error by default. IMHO we should rely on a single-source-of-truth implementation for validations.
https-everywhere/chromium/background-scripts/background.js
Lines 899 to 907 in 2bfa7ef
Contributor
There was a problem hiding this comment.
Seems like a good idea indeed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression from #19479 on wildcard support for disabled site (added since #18619) and some Travis lint errors.
@zoracon is the UX redesign work being blocked by the pandemic? It would be much nicer to have a consistent CSS styles/ framework to work with when adding new UI elements. IMHO, it would be better if we could provide visual clues to our users that wildcards are supported.