This repository was archived by the owner on Nov 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Run node utils/trivialize-rules/trivialize-targets.js #18068
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
Member
|
I know it's our normal policy to trivialize rules wherever possible, but have we done any memory analysis on this? I'm a bit worried about balooning the all_rules object... |
Contributor
|
@Hainish I believe complex regexes themselves use up lots of memory. |
Member
|
I missed the memory analysis above! Thanks for this, merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR for #17855
There is around 500+ targets which are gone from DNS, however I am not going to handle the fetch errors in the PR.
Besides, it surprises me that the node
URLobject accepts hostname with leading dots. This make the script from #18068 a little buggy. Since it is not possible to whitelist rulesets from schematic errors, Travis failed. The problematic rulesets are fixed in eef2855