Hello, Thank you for this work! There have been a patch made since then to remove the now deprecated "show counter". I plan on doing one more patch that shouldn't effect this branch, but once I do that Monday, I'll pull this down afterwards to my fork and review as soon as I can.

Also, are these dark mode changes also applicable in Chrome/Chromium?

@zoracon Thanks for your response.

I'll bring this branch up to date before Monday (e.g., remove the "show counter").

Also, are these dark mode changes also applicable in Chrome/Chromium?

The patch does not make any distinctions between Chromium and Firefox, it just has the "Dark Mode" toggle so that anyone with current browser can test it. Ideally, this patch should use the prefers-color-scheme media query, but this media query is not widely supported yet: desktop and Android Firefox 67 (see MDN), macOS Safari 12.1 (see MDN), Chrome/Chromium 76 (source). FYI, Firefox "resist fingerprinting" forces media query to always match for "light" option.

I'm not sure what is the best way forward on this, options are:

1. use only media query, no toggle, and support dark mode only on newer browsers (low maintenance cost, no JS code).
2. use manual toggle even if media query is supported, as I do currently (low maintenance cost, but poor user experience)
3. detect whether media query is supported with JS API and if supported rely on it, otherwise present the manual toggle (higher maintenance cost, but good user experience).

I would very much prefer option 3 (because it has the best UX), but it does have a few edge cases to test.

Update: I just force-pushed after git pull upstream master --rebase to simplify the review of the commit.

Can you fix merge conflicts?

@pipboy96 I resolved conflicts via the GitHub online interface, but I'll also test it for real as well. I'll comment when I'm done.

Update: so something between Git and GitHub was weird and it didn't allow me to push normally, so I force-pushed. The old branch up to this point can be found on 17882-old.

The DevTools pane no longer shows up, even on the master branch. As far as I see, the panel code was removed. Is there a replacement for it? There is still an option to "Show Devtools tab", but I'm not sure what it does.

Edit: fix repository -> branch

@pipboy96 I removed the explicit option to use dark mode because the prefers-color-scheme media query is supported widely (Chrome 76+ and Firefox 67+). If needed, I can add it back. The only reason to add it back I could think of is to allow it in Firefox 60 ESR and obscure configurations which disable media queries via Firefox fingerprinting flag.

@bershanskiy Do you have any plans to continue work on this?

@pipboy96 Yes, I do. I just got swamped with other stuff.

Related PR: #18992.

@bershanskiy If you want to continue work on this, feel free to ask for this PR to be reopened.