Add script to trivialize some left-wildcard targets by cschanaj · Pull Request #17855 · EFForg/https-everywhere · GitHub

This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Collaborator

cschanaj commented May 1, 2019 •

edited

Loading

this supersedes #17842 and is ready for review and merging. thanks.

P.S. there is no need to rush for the major release in #17711 .

cc @pipboy96 @zoracon @Hainish

Chan Chak Shing added 2 commits

May 1, 2019 16:02


          Add script to trivialize some left-wildcard targets

486ce24


          Update utils/trivialize-rules/trivialize-targets.js

3a6b0dc

cschanaj requested review from Hainish and zoracon

May 1, 2019 08:20

pipboy96 reviewed

View reviewed changes

utils/trivialize-rules/trivialize-targets.js Show resolved Hide resolved

pipboy96 reviewed

View reviewed changes

utils/trivialize-rules/trivialize-targets.js Show resolved Hide resolved

pipboy96 reviewed

View reviewed changes

utils/trivialize-rules/trivialize-targets.js Outdated Show resolved Hide resolved

pipboy96 reviewed

View reviewed changes

utils/trivialize-rules/trivialize-targets.js Outdated Show resolved Hide resolved

pipboy96 reviewed

View reviewed changes

utils/trivialize-rules/trivialize-targets.js Outdated Show resolved Hide resolved

pipboy96 reviewed

View reviewed changes

utils/trivialize-rules/trivialize-targets.js Outdated Show resolved Hide resolved

pipboy96 reviewed

View reviewed changes

utils/trivialize-rules/trivialize-targets.js Outdated Show resolved Hide resolved

pipboy96 reviewed

View reviewed changes

utils/trivialize-rules/trivialize-targets.js Show resolved Hide resolved

pipboy96 reviewed

View reviewed changes

utils/trivialize-rules/trivialize-targets.js Outdated Show resolved Hide resolved

pipboy96 reviewed

View reviewed changes

utils/trivialize-rules/trivialize-targets.js Show resolved Hide resolved


          Update utils/trivialize-rules/trivialize-targets.js

a40cc6e

pipboy96 added the toolchain label

pipboy96 reviewed

View reviewed changes

utils/trivialize-rules/trivialize-targets.js Outdated Show resolved Hide resolved

pipboy96 reviewed

View reviewed changes

utils/trivialize-rules/trivialize-targets.js Show resolved Hide resolved


          Update utils/trivialize-rules/trivialize-targets.js

c0e65f7

Contributor

pipboy96 commented May 1, 2019

@cschanaj Is there a reason to prefer " over '? Same issue exists in the extension itself. Both are used without any consistency.

Collaborator Author

cschanaj commented May 1, 2019 •

edited

Loading

this directory use prettier as the preferred linter (a choice from its original author). ~~I just follow his practices.~~ You're right, single quote should used as per #16029 (comment)


          prettier --write --single-quote trivialize-targets.js

04a2dee

cschanaj mentioned this pull request

Fix rulesets with problematic targets/ rewrites #17965

Closed

72 tasks

Collaborator Author

cschanaj commented Jun 5, 2019

@Hainish would you be interested in looking into this, possibly before the next ruleset release?

Member

Hainish commented Jun 6, 2019

I've reviewed and made a few changes here: #18062

@cschanaj please review my changes and make sure the clarifications are actually accurate. Otherwise, good to merge. Great work, and thanks for this!

Hainish merged commit be134ca into EFForg:master

cschanaj mentioned this pull request

Run node utils/trivialize-rules/trivialize-targets.js #18068

Merged

cschanaj deleted the script-to-trivialize-targets branch

June 7, 2019 04:37

cschanaj mentioned this pull request

Fix WebExtension Excessive Memory Usage #12232

Closed

24 tasks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels