-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update ruleset: Omtrdc.net #16453
Update ruleset: Omtrdc.net #16453
Conversation
|
Does this actually change/fix something? |
| to="https://$1.$2.omtrdc.net/" /> | ||
|
|
||
| <rule from="^http://([\w-]+)\.d([1-3])\.sc\.omtrdc\.net/" | ||
| to="https://$1.d$2.sc.omtrdc.net/" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found that regex groups become potentially problematic over time. Could you take the possible targets and list them above? Or perhaps they should rely on the wildcard above? Otherwise that would be preferred with the trivial rule <rule from="^http:" to="https:" /> still in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wildcard <target> is necessary because all subdomains exist.
I don't see a way to do the <rule>s without regex groups. We want to redirect http://a.sc.omtrdc.net but not http://a.a.sc.omtrdc.net.
|
@injust would be great if you could have a look here. |
|
The existing ruleset would redirect It would also force HTTPS on a URL like |
No description provided.