feat(forms): update submit function to accept options object #66810
+369
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
mmalerba
requested review from
alxhub,
kirjs and
leonsenft
and removed request for
crisbeto and
devversion
leonsenft
requested changes
Jan 29, 2026
Changes the `submit` function signature to accept a `FormSubmitOptions` object instead of a direct action callback. This allows for more flexibility, including: - `action`: The standard submit action to perform with the data. - `onInvalid`: A callback to execute when the submit action is not triggered due to failing validation - `ignoreValidators`: Controls whether pending validators or invalid validators should be ignored Also updates the return value of `submit` to a `Promise<boolean` to indicate submission success.
Updates FormOptions to accept a submission configuration object. This allows defining default submit options (action, validation behavior, etc.) when creating the form, which can be overridden when calling submit().
leonsenft
approved these changes
Jan 30, 2026
| ...(options ?? {}), | ||
| } as Partial<FormSubmitOptions<TModel>>); | ||
| const action = opts?.action; | ||
| if (!action) { |
Contributor
There was a problem hiding this comment.
I think I may have missed the discussion about this, but is the desire to support two ways of specifying the submit action worth the complexity/error here?
Did we consider only supporting it at the form() level? Is there are case where users would define the form() action, and override it with local submit() behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
submitfunction signature to accept aFormSubmitOptionsobject instead of a direct action callback.This allows for more flexibility, including:
action: The standard submit action to perform with the data.onInvalid: A callback to execute when the submit action is not triggered due to failing validationignoreValidators: Controls whether pending validators or invalid validators should be ignoredAlso updates the return value of
submitto aPromise<booleanto indicate submission success.Updates
FormOptionsto accept asubmissionconfiguration object.This allows defining default submit options (action, validation behavior, etc.)
when creating the form, which can be overridden when calling
submit().