Skip to content

Added missing 'shell_env_params' in redis.jsonc #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bpkroth merged 1 commit into from
Jun 12, 2024
Merged

Added missing 'shell_env_params' in redis.jsonc #754

bpkroth merged 1 commit into from
Jun 12, 2024
+5 −0

Conversation

@DelphianCalamity
Copy link
Contributor

@DelphianCalamity DelphianCalamity commented Jun 12, 2024

These missing environment variables were causing the Redis benchmark to fail.

@DelphianCalamity DelphianCalamity requested a review from a team as a code owner June 12, 2024 03:12
bpkroth
bpkroth approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
We'll eventually need to add end-to-end tests in #332, but not here.

@bpkroth bpkroth enabled auto-merge (squash) June 12, 2024 16:45
@bpkroth bpkroth merged commit ecfb5be into microsoft:main Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpkroth bpkroth bpkroth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DelphianCalamity @bpkroth