-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Added dynamic delegate for UIPopoverPresentationController
#359
base: master
Are you sure you want to change the base?
Added dynamic delegate for UIPopoverPresentationController
#359
Conversation
|
👍 |
1 similar comment
|
👍 |
fabb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import missing in BlocksKit+UIKit.h
…BlocksKit+UIKit` header
fabb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BlocksKit supports according to the podspec a minimum iOS target of iOS 6. The UIPopoverPresentationController only is available from iOS 8 on. So either some #ifdefs are needed, or the minimum iOS version in the podspec should be raised.
|
@fabb regarding the minimum iOS target: Since the files in this PR add a The Also compare with the |
|
|
||
| @implementation A2DynamicUIPopoverPresentationControllerDelegate | ||
|
|
||
| - (BOOL)popoverControllerShouldDismissPopover:(UIPopoverPresentationController *)popoverPresentationController |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong method signature, crashes at runtime
| return should; | ||
| } | ||
|
|
||
| - (void)popoverControllerDidDismissPopover:(UIPopoverPresentationController *)popoverPresentationController |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong method signature, crashes at runtime
No description provided.