Skip to content
This repository was archived by the owner on Jun 2, 2018. It is now read-only.

Conversation

@mathaeus
Copy link

No description provided.

@soberman
Copy link

👍

1 similar comment
@PatrickDotStar
Copy link

👍

Copy link

@fabb fabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import missing in BlocksKit+UIKit.h

Copy link

@fabb fabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BlocksKit supports according to the podspec a minimum iOS target of iOS 6. The UIPopoverPresentationController only is available from iOS 8 on. So either some #ifdefs are needed, or the minimum iOS version in the podspec should be raised.

@mathaeus
Copy link
Author

@fabb regarding the minimum iOS target: Since the files in this PR add a UIPopoverPresentationController category I don't think this is necessary.

The UIPopoverPresentationController interface itself has the NS_CLASS_AVAILABLE_IOS(8_0) macro. This means you can use the class and therefore the category only on iOS 8 or higher.

Also compare with the UIPopoverPresentationControllerDelegate. The protocol has no NS_CLASS_AVAILABLE_IOS macro.


@implementation A2DynamicUIPopoverPresentationControllerDelegate

- (BOOL)popoverControllerShouldDismissPopover:(UIPopoverPresentationController *)popoverPresentationController
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong method signature, crashes at runtime

return should;
}

- (void)popoverControllerDidDismissPopover:(UIPopoverPresentationController *)popoverPresentationController
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong method signature, crashes at runtime

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants