-
Notifications
You must be signed in to change notification settings - Fork 486
[ITS-tracking] Use MCTruthContainer to manage MC labels #6431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @shahor02 @iouribelikov |
|
@mconcas OK. Meanwhile, perhaps you can add the fake patterns flag we have discussed. |
04ea900 to
7d56193
Compare
|
@mconcas This PR seems to break the macro/run_trac_alice3.C, see o2-dataflow CI |
1c73683 to
0971458
Compare
Thanks, I did a quick fix. |
|
@mconcas this one also seems to be genuine: |
Thanks! yes, I was expecting that, will fix that same way (weird that those two did not come up together, would've saved some CI cycles). |
0971458 to
8c85252
Compare
|
Btw, @mpuccio will anyway remove |
|
@mconcas : Is this ready to be merged? |
|
@davidrohr : will not change but we are waiting #5911 |
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
|
... |
This is a frist try to use MCTruthContainer directly. Open for discussion.
TODO:
These are 1000 pp events with minimum track length = 7 clusters.

Current state (AliceO2/dev):
With this PR:

Difference is subtle but non zero.