Skip to content

Conversation

@mconcas
Copy link
Collaborator

@mconcas mconcas commented Jun 15, 2021

This is a frist try to use MCTruthContainer directly. Open for discussion.

TODO:

  • Generalize fake tagging algorithm to cope with multiple labels
  • Extend MClabels comparison logic wherever it is used
  • Test consistency and debug (high pt cutoff in efficiency?)

These are 1000 pp events with minimum track length = 7 clusters.
Current state (AliceO2/dev):
pp_eff_dev

With this PR:
pp_eff_mcTruthContainer

Difference is subtle but non zero.

@mconcas
Copy link
Collaborator Author

mconcas commented Jun 16, 2021

Hi @shahor02 @iouribelikov
I compared the effects of the PR before and after the mcTruth usage. In the presented plots there are some tiny improvements, not dramatic, as also expected with this configuration.
I guess then the tagging algorithm seems to work.
Given that the impact is not so high I was considering to postpone the merging and wait for the work of tracking multiple rofs to be merged and adapt everything accordingly.

@shahor02
Copy link
Collaborator

@mconcas OK. Meanwhile, perhaps you can add the fake patterns flag we have discussed.

@mconcas mconcas force-pushed the its-tracker-smoother branch from 04ea900 to 7d56193 Compare June 17, 2021 09:53
@mconcas mconcas marked this pull request as ready for review June 17, 2021 09:55
iouribelikov
iouribelikov previously approved these changes Jun 28, 2021
@shahor02
Copy link
Collaborator

@mconcas This PR seems to break the macro/run_trac_alice3.C, see o2-dataflow CI

@mconcas mconcas force-pushed the its-tracker-smoother branch from 1c73683 to 0971458 Compare June 30, 2021 12:04
@mconcas mconcas requested a review from a team as a code owner June 30, 2021 12:04
@mconcas
Copy link
Collaborator Author

mconcas commented Jun 30, 2021

@mconcas This PR seems to break the macro/run_trac_alice3.C, see o2-dataflow CI

Thanks, I did a quick fix.
This macro will anyways be removed as soon as I make ALICE 3 tracking to work with MCtruth containers.

@shahor02
Copy link
Collaborator

shahor02 commented Jul 1, 2021

@mconcas this one also seems to be genuine:

Info in <TUnixSystem::ACLiC>: creating shared library /mnt/mesos/sandbox/sandbox/o2/sw/BUILD/730998ec31b50f6f088b0fb856522e72e0f32253/O2/compiled_macros//mnt/mesos/sandbox/sandbox/o2/sw/SOURCES/O2/6431/0/Detectors/Upgrades/ALICE3/TRK/macros/ALICE3toAO2D_C.so
In file included from input_line_11:6:
/mnt/mesos/sandbox/sandbox/o2/sw/SOURCES/O2/6431/0/Detectors/Upgrades/ALICE3/TRK/macros/ALICE3toAO2D.C:431:13: error: no member named 'addClusterLabelToLayer' in 'o2::its::ROframe'
      event.addClusterLabelToLayer(layer, o2::MCCompLabel(hit.GetTrackID(), iEvent, iEvent, false));
      ~~~~~ ^
Error in <ACLiC>: Dictionary generation failed!

@mconcas
Copy link
Collaborator Author

mconcas commented Jul 1, 2021

@mconcas this one also seems to be genuine:

Info in <TUnixSystem::ACLiC>: creating shared library /mnt/mesos/sandbox/sandbox/o2/sw/BUILD/730998ec31b50f6f088b0fb856522e72e0f32253/O2/compiled_macros//mnt/mesos/sandbox/sandbox/o2/sw/SOURCES/O2/6431/0/Detectors/Upgrades/ALICE3/TRK/macros/ALICE3toAO2D_C.so
In file included from input_line_11:6:
/mnt/mesos/sandbox/sandbox/o2/sw/SOURCES/O2/6431/0/Detectors/Upgrades/ALICE3/TRK/macros/ALICE3toAO2D.C:431:13: error: no member named 'addClusterLabelToLayer' in 'o2::its::ROframe'
      event.addClusterLabelToLayer(layer, o2::MCCompLabel(hit.GetTrackID(), iEvent, iEvent, false));
      ~~~~~ ^
Error in <ACLiC>: Dictionary generation failed!

Thanks! yes, I was expecting that, will fix that same way (weird that those two did not come up together, would've saved some CI cycles).
Those macros need anyway to be sorted out. @ddobrigk as anticipated, we need to bring upstream something that works. With 3+1D tracking coming soon I guess we'll do a single larger iteration to streamline ALICE 3 tracking.

@mconcas mconcas force-pushed the its-tracker-smoother branch from 0971458 to 8c85252 Compare July 1, 2021 09:17
@mconcas
Copy link
Collaborator Author

mconcas commented Jul 1, 2021

Btw, @mpuccio will anyway remove macro/run....alice3.C so we will maintain only one in the upgrades dedicated directory

@davidrohr
Copy link
Collaborator

@mconcas : Is this ready to be merged?

@mconcas
Copy link
Collaborator Author

mconcas commented Jul 14, 2021

@davidrohr : will not change but we are waiting #5911

@github-actions
Copy link
Contributor

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

@github-actions github-actions bot added the stale label Aug 14, 2021
@github-actions github-actions bot closed this Aug 20, 2021
@mconcas
Copy link
Collaborator Author

mconcas commented Aug 20, 2021

...

@mconcas mconcas reopened this Aug 20, 2021
@github-actions github-actions bot closed this Aug 26, 2021
@mconcas mconcas reopened this Aug 26, 2021
@github-actions github-actions bot closed this Sep 1, 2021
@mconcas mconcas reopened this Sep 1, 2021
@github-actions github-actions bot closed this Sep 7, 2021
@mconcas mconcas removed the stale label Sep 7, 2021
@mconcas mconcas reopened this Sep 7, 2021
@mconcas mconcas deleted the its-tracker-smoother branch November 11, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants